Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Requiredness Check Bug #15149

Merged
merged 6 commits into from
Jul 24, 2024
Merged

Conversation

spencerrlongg
Copy link
Collaborator

Description

Check if array and then requiredness

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Added test to make sure Asset Edit page is accessible

  • Test A
  • Test B

Test Configuration:

  • PHP version: 8.1

Copy link

what-the-diff bot commented Jul 23, 2024

PR Summary

  • Improved Validation in Helper Functions
    The update introduces an additional check in our helper functions. This enhancement ensures that all necessary fields are filled in correctly before any process that depends on these fields is initiated.

  • Increased Test Coverage with New File
    A new test file titled EditAssetTest.php was added to our testing suite. This inclusion is set to improve our ability to catch potential errors before they become a problem, as it targets editing operations on assets specifically. This leads to overall better software stability and trustworthiness.

@spencerrlongg
Copy link
Collaborator Author

hold on merge resolution screwed this up

@spencerrlongg
Copy link
Collaborator Author

alright, should be good to go now

@snipe snipe merged commit 90a2a80 into snipe:develop Jul 24, 2024
9 checks passed
@snipe
Copy link
Owner

snipe commented Jul 24, 2024

Screenshot 2024-07-24 at 10 39 15 AM

On licenses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants