-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added status labels to confirmation emails #15192
Conversation
PR Summary
|
…ckout adds Status labels to check in and out emails
Why you bork tests?? |
…ipe-it into status_labels_check_emails
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without actually testing, this looks good to me. Let me know if you'd like me to actually test it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we pull the indent on the new section in the mail blades? I've seen them parse funny in the past, since it's markdown and not HTML.
indents removed 👍 |
Perfect, ty! (I never quite figured out what triggered the “sometimesy-ness” of those markdown blades failing, it would happen kinda randomly. Indents in markdown are block quotes, so I sort of get it, but was always hard to predict.) |
Description
This adds the asset's status to accepted and declined asset notifications
Accepted:
Declined:
Check-in:
Check out:
Fixes #[sc-26164] [sc-26133]
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: