Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added status labels to confirmation emails #15192

Merged
merged 8 commits into from
Aug 13, 2024

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Jul 30, 2024

Description

This adds the asset's status to accepted and declined asset notifications

Accepted:
image

Declined:
image

Check-in:
image

Check out:
image

Fixes #[sc-26164] [sc-26133]

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Jul 30, 2024

PR Summary

  • Inclusion of 'item_status' in Store and Mail Methods
    Enhanced functionality of the 'AcceptanceController' to accept and process an 'item_status' field.

  • Incorporation of 'item_status' in Acceptance Notifications
    Expanded capability of the 'AcceptanceAssetAcceptedNotification' and 'AcceptanceAssetDeclinedNotification' constructors to allow handling of an 'item_status' field.

  • Addition of 'status' in Checkout Mail Method
    Introduced a 'status' field in the 'CheckoutAssetNotification' toMail method for improved information handling.

  • Application of 'item_status' in Asset Acceptance blade
    Introduced the 'item_status' field to 'asset-acceptance.blade.php' for better data representation.

  • Application of 'status' in Checkout Asset blade
    Included the 'status' field in 'checkout-asset.blade.php', powering more comprehensive data demonstration.

@snipe
Copy link
Owner

snipe commented Jul 31, 2024

Why you bork tests??

Copy link
Collaborator

@spencerrlongg spencerrlongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without actually testing, this looks good to me. Let me know if you'd like me to actually test it out.

@snipe snipe changed the title adds status labels to confirmation emails Added status labels to confirmation emails Aug 13, 2024
Copy link
Owner

@snipe snipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pull the indent on the new section in the mail blades? I've seen them parse funny in the past, since it's markdown and not HTML.

@Godmartinz
Copy link
Collaborator Author

indents removed 👍

@Godmartinz Godmartinz requested a review from snipe August 13, 2024 17:22
@snipe
Copy link
Owner

snipe commented Aug 13, 2024

Perfect, ty! (I never quite figured out what triggered the “sometimesy-ness” of those markdown blades failing, it would happen kinda randomly. Indents in markdown are block quotes, so I sort of get it, but was always hard to predict.)

@snipe snipe merged commit e9fc455 into snipe:develop Aug 13, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants