Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed accessories and consumables not being logged correctly during bulk check-in #15221

Merged
merged 33 commits into from
Aug 8, 2024
Merged

Fixed accessories and consumables not being logged correctly during bulk check-in #15221

merged 33 commits into from
Aug 8, 2024

Commits on Jul 24, 2024

  1. Add failing test for accessories and consumables checkin

    @marcusmoore
    marcusmoore committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    7161b64 View commit details
    Browse the repository at this point in the history

  2. Add accessory and consumable specific checkin methods

    @marcusmoore
    marcusmoore committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    44dbbeb View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Add another user into the mix

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    78a0417 View commit details
    Browse the repository at this point in the history

  2. Improve readability

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    480e4f3 View commit details
    Browse the repository at this point in the history

  3. Improve variable name

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    bfebcdc View commit details
    Browse the repository at this point in the history

  4. Improve readability

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    364775d View commit details
    Browse the repository at this point in the history

  5. Add permission check

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    4ed3347 View commit details
    Browse the repository at this point in the history

  6. Add validation test

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    5ecdb7e View commit details
    Browse the repository at this point in the history

  7. Remove comment

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    e3049ff View commit details
    Browse the repository at this point in the history

  8. Add assertions

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    b06501d View commit details
    Browse the repository at this point in the history

  9. Add todo comments

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    67b3ab8 View commit details
    Browse the repository at this point in the history

  10. Add assertion

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    8a206a6 View commit details
    Browse the repository at this point in the history

  11. Add assertion for success message

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    5786ff5 View commit details
    Browse the repository at this point in the history

  12. Assert redirected to correct place

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    fc405d9 View commit details
    Browse the repository at this point in the history

  13. Add assertion to ensure user cannot perform bulk actions on self

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    5cd9dd4 View commit details
    Browse the repository at this point in the history

  14. Scaffold two tests

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    d1bb3ef View commit details
    Browse the repository at this point in the history

  15. Implement test for assets

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    16aa475 View commit details
    Browse the repository at this point in the history

  16. Remove comment

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    59b7d5d View commit details
    Browse the repository at this point in the history

  17. Re-order helpers

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    1acd24f View commit details
    Browse the repository at this point in the history

  18. Move test class

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    a556932 View commit details
    Browse the repository at this point in the history

  19. Improve readability

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    96fafa6 View commit details
    Browse the repository at this point in the history

  20. Implement test case

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    35e7a31 View commit details
    Browse the repository at this point in the history

  21. Remove code handled by ConsumableAssignment:: call above

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    392d344 View commit details
    Browse the repository at this point in the history

  22. Remove todo outside of scope

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    1c664af View commit details
    Browse the repository at this point in the history

  23. Formatting

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    01e4382 View commit details
    Browse the repository at this point in the history

  24. Formatting

    @marcusmoore
    marcusmoore committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    17eccfc View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Merge branch 'develop' into fixes/bulk-checkin-logging 

    # Conflicts:
#	app/Http/Controllers/Users/BulkUsersController.php
    @marcusmoore
    marcusmoore committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    f2b78d1 View commit details
    Browse the repository at this point in the history

  2. Use new accessory checkout relationship

    @marcusmoore
    marcusmoore committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    94e00b8 View commit details
    Browse the repository at this point in the history

  3. Fix namespace

    @marcusmoore
    marcusmoore committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    2a8ac81 View commit details
    Browse the repository at this point in the history

  4. Switch to snake case

    @marcusmoore
    marcusmoore committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    a220986 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Merge branch 'develop' into fixes/bulk-checkin-logging 

    # Conflicts:
#	app/Http/Controllers/Users/BulkUsersController.php
    @marcusmoore
    marcusmoore committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    41437e4 View commit details
    Browse the repository at this point in the history

  2. Make diff cleaner

    @marcusmoore
    marcusmoore committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    d03baa4 View commit details
    Browse the repository at this point in the history

  3. Improve variable name

    @marcusmoore
    marcusmoore committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    4a2d2f7 View commit details
    Browse the repository at this point in the history