-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added #15312: Add checkin due in days setting #15314
Added #15312: Add checkin due in days setting #15314
Conversation
…pers in the due for checkin page. Currently this uses the audit warning days but a sperated setting gives the possibility of defineing different values for each field.
PR Summary
|
Thanks for this - this looks good. Trying to figure out why the tests are failing. |
Congrats on merging your first pull request! 🎉🎉🎉 |
Uh, wait, aren't we missing a migration here? |
Signed-off-by: snipe <[email protected]>
Indeed, idk why the migration wasn't included in the commit. |
It's all good, I added it |
Signed-off-by: snipe <[email protected]>
This PR implements a setting to specify the number of days before an asset appears on the due for check-in page. Currently, this uses the "audit warning days" setting, but a separate setting allows for different values for each field.
Fixes #15312
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: