Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added #15312: Add checkin due in days setting #15314

Merged

Conversation

Glukose1
Copy link

This PR implements a setting to specify the number of days before an asset appears on the due for check-in page. Currently, this uses the "audit warning days" setting, but a separate setting allows for different values for each field.

image

Fixes #15312

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Different values have been assigned for both settings and both are saved correctly. The "Due for Checkin" page references the new setting.

Test Configuration:

  • PHP version: 8.2.20
  • MySQL version: Ver 15.1 Distrib 10.11.6-MariaDB
  • Webserver version: Apache/2.4.59 (Debian)
  • OS version: Debian GNU/Linux 12.6 (bookworm)

Checklist:

…pers in the due for checkin page. Currently this uses the audit warning days but a sperated setting gives the possibility of defineing different values for each field.
Copy link

what-the-diff bot commented Aug 16, 2024

PR Summary

  • Added 'due_checkin_days' property to Settings Controller
    This enhancement allows the application to handle properties related to the time frame for due check-ins, defined within our system.

  • Modified interval variable to use 'due_checkin_days' property
    This change allows for better integration of the 'due_checkin_days' property within our assets model, making our time tracking components more efficient when calculating due dates.

  • Added language resource entries for 'due_checkin_days'
    To improve our international user experience, we have integrated new language translation entries for 'due_checkin_days' in our English language resource file.

  • Updated title on hardware check-in page
    The page title on the hardware check-in has been updated to reflect the new 'due_checkin_days' property, ultimately giving our users better context.

  • Integration of form field for 'due_checkin_days' in settings
    A new form field has been introduced in the alert settings page concerning 'due_checkin_days'. This field increases ease of use for our clients and boosts self-service capabilities on the platform.

@snipe
Copy link
Owner

snipe commented Aug 16, 2024

Thanks for this - this looks good. Trying to figure out why the tests are failing.

@snipe snipe merged commit de29c1d into snipe:develop Aug 16, 2024
5 of 9 checks passed
Copy link

welcome bot commented Aug 16, 2024

Congrats on merging your first pull request! 🎉🎉🎉

@snipe
Copy link
Owner

snipe commented Aug 16, 2024

Uh, wait, aren't we missing a migration here?

snipe added a commit that referenced this pull request Aug 16, 2024
@Glukose1 Glukose1 deleted the features/add_setting_due_for_checkin_in_days branch August 16, 2024 10:06
@Glukose1
Copy link
Author

Indeed, idk why the migration wasn't included in the commit.

@snipe
Copy link
Owner

snipe commented Aug 16, 2024

It's all good, I added it

FlorentDotMe pushed a commit to TelecomsSansFrontieres/snipe-it that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants