Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed docker startup scripts coherently. #15358

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

r-xyz
Copy link
Contributor

@r-xyz r-xyz commented Aug 21, 2024

Description

This PR renames all startup scripts for docker images coherently with 65ae03c.

No new features introduced.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • docker build

Test Configuration:

  • PHP version: Docker
  • MySQL version Docker
  • Webserver version Docker
  • OS version Docker

Checklist:

Copy link

what-the-diff bot commented Aug 21, 2024

PR Summary

This Pull Request makes updates to the Dockerfile configurations. Dockerfiles are scripts that contain collections of commands for constructing an image that can be used to deploy a container on the Docker platform.

  • Updated Naming Conventions in Dockerfiles
    The main scripts that were earlier named as entrypoint_alpine.sh and docker-entrypoint.sh have been renamed to startup_alpine.sh and startup_alpine_fpm.sh respectively. This might make it more intuitive for users understanding the code.

  • Changes in Docker Directives
    The 'command' (CMD) and 'entry point' (ENTRYPOINT) directives in the Dockerfiles are commands that are executed when a new container is created. We've changed these directives. In Dockerfile.alpine, the CMD directive has been switched from entrypoint.sh to startup.sh. Similarly, in Dockerfile.fpm-alpine, both ENTRYPOINT and CMD directives have been altered from docker-snipeit-entrypoint and docker-php-entrypoint to startup.sh.

These changes could make the startup processes within Docker containers more streamlined, thus enhancing overall docker container performance.

@r-xyz r-xyz changed the base branch from master to develop August 21, 2024 10:00
Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Thanks!

@snipe snipe merged commit 6fdce3c into snipe:develop Aug 21, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants