Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that the user exists before trying to print #15408

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Aug 29, 2024

This is likely more important for the demo since we re-seed that info frequently, but this just does a redirect if the user doesn't exist anymore versus 500ing. Fixed RB-3840.

@snipe snipe merged commit 58e366a into develop Aug 29, 2024
3 of 8 checks passed
@snipe snipe deleted the redirect-on-print-if-user-invalid branch August 29, 2024 10:08
Copy link

what-the-diff bot commented Aug 29, 2024

PR Summary

  • Improvement of the Print Inventory Functionality
    The 'printInventory' function contained within Users' management has been upgraded. It now checks if the user ID provided actually exists before proceeding. This is meant to ensure that an error isn't thrown when an unknown or nonexistent user ID is entered.
  • Notification Upon User Absence
    In case a user does not exist, the system will not crash or hang. Instead, an appropriate redirection is made back to users' listing area and an error message is displayed. This guides you to the right place if the person you're searching hasn't signed up yet.
  • Enhanced Data Retrieval Method
    If a user is found, the enhanced 'printInventory' method retrieves more user-related data, such as assets, accessories, consumables, and licenses. This change is aimed to provide a comprehensive inventory view for each user.
  • Removal of Author Annotation
    The author annotation that had no functional impact but increased clutter in the 'UsersController.php' file was removed, ensuring cleaner, leaner, and more efficient code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant