Fixed priority for category eula vs default eula

[Godmartinz]

Description

This adds a check to see if the use_default_eula is enabled while the category eula_text is populated. properly selecting the eula intended to be used now.

Fixes #[sc-26637]

Type of change

Please delete options that are not relevant.

• [x ] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Test A
• Test B

Test Configuration:

• PHP version:
• MySQL version
• Webserver version
• OS version

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[what-the-diff]

PR Summary

• Modification to getEula() function in Asset.php
  The function has been updated to include an additional check within its operation. This newly added condition verifies whether the model category is using the default End User License Agreement (EULA) or not. If it is not using the default EULA, the function will provide the standard EULA text from system settings, offering consistency across different model categories.

[marcusmoore]

This works but can we add a test case for it?

Here is a test that fails on develop and passes on this branch:

public function testDefaultEulaIsSentWhenSetInCategory()
{
    Notification::fake();

    $this->settings->setEula('My Custom EULA Text');

    $user = User::factory()->create();

    $category = Category::factory()->create([
        'use_default_eula' => 1,
        'eula_text' => 'EULA Text that should not be used',
    ]);

    $model = AssetModel::factory()->for($category)->create();
    $asset = Asset::factory()->for($model, 'model')->create();

    $asset->checkOut($user, User::factory()->superuser()->create()->id);

    Notification::assertSentTo($user, CheckoutAssetNotification::class, function ($notification) {
        $content = $notification->toMail()->render();

        return str_contains($content, 'My Custom EULA Text') && !str_contains($content, 'EULA Text that should not be used');
    });
}

This is the change to Tests\Support\Settings (drop it right above the set() method):

public function setEula($text = 'Default EULA text')
{
    return $this->update(['default_eula_text' => $text]);
}

I think we can add it to NotificationTest
(we should probably move that class to Feature\Notifications\Email\ but we don't need to do it now...)

[marcusmoore]

Looks good but one more thing...

[marcusmoore]

Was this supposed to be included?

[Godmartinz]

whoops those are changes for something else.

[marcusmoore]

Looks good to me 👍🏾

[snipe]

Is that setEula() method just for the tests?

[snipe]

What is this doing?

[marcusmoore]

Yeah it's only used for testing. In this case it's in NotificationTest@testDefaultEulaIsSentWhenSetInCategory on line 40. It's setting it in the application's global settings so we can assert against it further down.