Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UI tests for creating accessories #15469

Merged
merged 6 commits into from
Sep 10, 2024

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR adds some simple UI tests for the checking permissions on the accessory index and accessory create pages, along with validation and assertions that accessories can be created via the UI.

Type of change

  • Testing

Copy link

what-the-diff bot commented Sep 9, 2024

PR Summary

  • Addition of Accessory View Permission Test
    A new test has been included to validate the requirement of permissions for viewing the list of accessories. This ensures that only authorized users have access to this list, providing an added layer of security.

  • Extension of Create Accessory Tests
    We've further enriched our test coverage with regard to the process of adding new accessories. This includes:

    • Guaranteeing that only those with the correct permissions can access the page to add new accessories. This restricts the ability to make additions to those who are rightfully allowed it.
    • Ensuring that the page for adding new accessories is loaded successfully. This ensures that the page is functional at all times.
    • Validating that only correct and valid data can be used to create an accessory. This preemptively avoids the creation of accessories with inappropriate or misleading data.
    • Lastly, providing an assurance that an accessory can indeed be created when provided with appropriate data. This ensures the overall functionality and integrity of the system.

@snipe snipe merged commit 6f44441 into snipe:develop Sep 10, 2024
9 checks passed
@marcusmoore marcusmoore deleted the accessory_tests branch September 10, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants