Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mail notification field status label not updating #15531

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

Godmartinz
Copy link
Collaborator

Description

This refreshes the assetstatus relationship before sending mail notifications for checkout. Not sure why, but the new value was present everywhere except when it got to toMail() method. Giving it a refresh solved the issue.

Fixes #15515

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Sep 19, 2024

PR Summary

  • Improved Email System Efficiency
    The update makes our system more streamlined when sending emails by pre-loading 'asset status' information related to an item. This allows you to receive emails faster and with comprehensive information regarding the status of your items.

@Godmartinz Godmartinz changed the title Fixed mail notification status label not updating Fixed mail notification field status label not updating Sep 19, 2024
@snipe snipe merged commit eef487d into snipe:develop Sep 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants