Fixed divide by zero bug in depreciation transformer

[Godmartinz]

Description

This changes the conditional statement in the depreciations transformer. It will now give you a monthly depreciation by eol correctly. If we are calculating the monthly depreciation by eol, it should not be concerned with if there is a depreciation model anymore, because a depreciation model will always have its own eol. Therefore I have placed it outside of that conditional depreciation check. if eol is zero it should not try to divide by it, but rather return zero.
Fixes # [sc-20259]

Type of change

Please delete options that are not relevant.

• [x ] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Test A
• Test B

Test Configuration:

• PHP version:
• MySQL version
• Webserver version
• OS version

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[what-the-diff]

PR Summary

• Improved Calculation Efficiency

  • Simplified the process of calculating monthly depreciation, reducing unnecessary computation steps, which boosts system performance.

• Streamlined Depreciation Logic

  • The monthly depreciation calculation is now more straightforward when the 'end of life' (eol) term of an asset is defined, making the code cleaner and easier to maintain.

• Preserved Monthly Depreciation Computation

  • The logic for determining monthly depreciation based on the number of depreciation months remains, ensuring that the calculation accuracy remains intact.