Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1703629: Snowpark packaging does not actually ever log pip install error messages #1639

Closed
jamesweakley opened this issue Sep 30, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@jamesweakley
Copy link
Contributor

SnowCLI version

3.0.0rc2

Python version

3.10

Platform

Linux-6.8.0-45-generic-x86_64-with-glibc2.36

What happened

When building a snowpark package, any pip failures get reported as "returned non-zero exit status 1".

This is because although pip_wheel attempts to catch subprocess.CalledProcessError, that exception is never thrown unless you pass check=True to subprocess.run.

I tested this by editing the source locally and adding check=True, immediately I started getting back meaningful error messages.

Console output

No response

How to reproduce

No response

@github-actions github-actions bot changed the title Snowpark packaging does not actually ever log pip install error messages SNOW-1703629: Snowpark packaging does not actually ever log pip install error messages Sep 30, 2024
@sfc-gh-jsikorski sfc-gh-jsikorski added the enhancement New feature or request label Oct 1, 2024
@sfc-gh-turbaszek
Copy link
Contributor

Fixed in #1701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants