Snow 1703629 log pip error message #1701
Merged
+71
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| f"pip wheel finished with error code {result.returncode}. Please re-run with --verbose or --debug for more details." | ||
| ) | ||
| else: | ||
| log.info("Pip wheel command executed successfully") |
There was a problem hiding this comment.
Do we want spam this message?
There was a problem hiding this comment.
I kept that as I liked the log consistency - "running pip" -> "pip error" or "running pip" -> "pip success", no strong opinion though
Comment on lines
236
to
239
| f"pip wheel finished with error code {result.returncode}. Please re-run with --verbose or --debug for more details." | ||
| ) | ||
| else: | ||
| log.info("Pip wheel command executed successfully") |
There was a problem hiding this comment.
Please decide on one version 😄 pip wheel vs Pip wheel.
There was a problem hiding this comment.
pip wheel, fixed
tests_integration/test_package.py
Outdated
| @pytest.mark.integration | ||
| def test_incorrect_input(self, runner): | ||
| # TODO: refactor snowpark, so pip error is always thrown |
There was a problem hiding this comment.
For who is this TODO? Do we want to create jira ticket for it?
There was a problem hiding this comment.
Ah, it was for me from the morning, changes are already applied. Removed :D
sfc-gh-astus
approved these changes
Oct 10, 2024
sfc-gh-mraba
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Add test * implement fix * move test to integration * refactor * Fix tests * update release notes * review fixes
sfc-gh-mraba
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Add test * implement fix * move test to integration * refactor * Fix tests * update release notes * review fixes
sfc-gh-mraba
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Add test * implement fix * move test to integration * refactor * Fix tests * update release notes * review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Add pip error details to logs.
Small refactor of
download_unavailable_packages(raise exception earlier, as all usages were immediately raising in casesucceded==False)