Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NADE ownership to tests_common/deflake.py #1691

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Add NADE ownership to tests_common/deflake.py #1691

merged 1 commit into from
Oct 9, 2024

Conversation

sfc-gh-fcampbell
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

This file is part of a NADE initiative to reduce test flakiness, we should be codeowners on it.

@sfc-gh-fcampbell sfc-gh-fcampbell requested a review from a team as a code owner October 8, 2024 15:24
@sfc-gh-fcampbell sfc-gh-fcampbell enabled auto-merge (squash) October 8, 2024 15:25
This was referenced Oct 9, 2024
Merged
Merged
@sfc-gh-fcampbell sfc-gh-fcampbell merged commit 98ec4f8 into main Oct 9, 2024
18 of 19 checks passed
@sfc-gh-fcampbell sfc-gh-fcampbell deleted the frank-deflake-codeowners branch October 9, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-turbaszek sfc-gh-turbaszek sfc-gh-turbaszek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-fcampbell @sfc-gh-turbaszek