Snow 1711304 fix empty default handling in snowpark #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-astus
reviewed
Oct 9, 2024
| @@ -22,6 +22,8 @@ | |||
|
|
|||
| ## Fixes and improvements | |||
| * Fixed a bug that would cause the `deploy_root`, `bundle_root`, and `generated_root` directories to be created in the current working directory instead of the project root when invoking commands with the `--project` flag from a different directory. | |||
| * Fix handling empty default values for strings by `snow snowpark deploy`. | |||
There was a problem hiding this comment.
Empty, '' also misbehaved ;)
sfc-gh-pczajka
changed the title
sfc-gh-astus
approved these changes
Oct 10, 2024
sfc-gh-mraba
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Add test * test other types * implement fix * add tests for procedures * update release notes * undo auto style fixes on RELEASE-NOTES.md * simplify function test
sfc-gh-mraba
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Add test * test other types * implement fix * add tests for procedures * update release notes * undo auto style fixes on RELEASE-NOTES.md * simplify function test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Fix handling empty default values for strings by
snow snowpark deploy