Add package scripts warning back #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -103,7 +103,7 @@ def test_sql_templating_emits_counter( | |||
| CLICounterField.TEMPLATES_PROCESSOR: 0, | |||
| CLICounterField.PDF_TEMPLATES: 1, | |||
| CLICounterField.POST_DEPLOY_SCRIPTS: 1, | |||
| CLICounterField.PACKAGE_SCRIPTS: 0, | |||
| CLICounterField.PACKAGE_SCRIPTS: 1, | |||
There was a problem hiding this comment.
test files have package scripts, so this should be 1.
There was a problem hiding this comment.
Do we want to make the distinction that since the pdf is v1, then POST_DEPLOY_SCRIPTS should count as 0 then?
There was a problem hiding this comment.
i think it's something we can distinguish in the graphs themselves (like exclude package_scripts = 1). I do not want to touch the post_deploy_scripts part because the goal is to have the bulk part of the code operate in pdf v2 mode, and would make sense to keep the counters for this one with the post_deploy code itself.
It's basically a compromise.
| @@ -115,7 +115,6 @@ def test_sql_templating_emits_counter( | |||
| CLICounterField.TEMPLATES_PROCESSOR: 0, | |||
| CLICounterField.PDF_TEMPLATES: 1, | |||
| CLICounterField.POST_DEPLOY_SCRIPTS: 1, | |||
| CLICounterField.PACKAGE_SCRIPTS: 0, | |||
There was a problem hiding this comment.
this is PDF v2, so no need to emit metric for this one.
sfc-gh-fcampbell
previously approved these changes
Oct 22, 2024
sfc-gh-turbaszek
previously approved these changes
Oct 23, 2024
sfc-gh-melnacouzi
dismissed stale reviews from sfc-gh-turbaszek and sfc-gh-fcampbell
via
a096047
sfc-gh-melnacouzi
force-pushed
the
melnacouzi-readd-package-scripts-warning
branch
from
6148932
to
a096047
Compare
sfc-gh-turbaszek
approved these changes
Oct 23, 2024
sfc-gh-bdufour
approved these changes
Oct 23, 2024
sfc-gh-melnacouzi
deleted the
melnacouzi-readd-package-scripts-warning
branch
sfc-gh-melnacouzi
added a commit
that referenced
this pull request
Oct 23, 2024
sfc-gh-melnacouzi
added a commit
that referenced
this pull request
Oct 23, 2024
sfc-gh-melnacouzi
added a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Add package scripts warning back.
It disappeared due to the conversion of package scripts to post deploy scripts.