Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual test script for connectAsync #598

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Conversation

sfc-gh-ext-simba-ll
Copy link
Contributor

@sfc-gh-ext-simba-ll sfc-gh-ext-simba-ll commented Jul 27, 2023

These tests need manual interaction and cannot be added as part of automated test.

@sfc-gh-ext-simba-ll sfc-gh-ext-simba-ll requested a review from a team as a code owner July 27, 2023 22:38
EnableConnectAsyncTests.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #598 (d428cb9) into master (63ea42a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #598   +/-   ##
=======================================
  Coverage   84.80%   84.80%           
=======================================
  Files          56       56           
  Lines        5199     5199           
=======================================
  Hits         4409     4409           
  Misses        790      790           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sfc-gh-ext-simba-jy
Copy link
Collaborator

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-ext-simba-jy
Copy link
Collaborator

Hello Team, I'm John who took over Linda's PR.

@sfc-gh-igarish
Copy link
Collaborator

Hello Team, I'm John who took over Linda's PR.

Hi John, welcome aboard. If you have address the Dominic question in the PR then resolve it and ping him again to review it.

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy merged commit ee8e09e into master Aug 8, 2023
21 checks passed
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy deleted the manualtest branch August 8, 2023 18:15
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants