Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-890305: Bump minor urllib and delete vm2 exclusion #614

Merged
merged 1 commit into from
Aug 10, 2023
Merged

SNOW-890305: Bump minor urllib and delete vm2 exclusion #614

merged 1 commit into from
Aug 10, 2023

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

@sfc-gh-dprzybysz sfc-gh-dprzybysz commented Aug 10, 2023 •
edited
Loading

Description

  • Bump urllib 2.x minor version
  • remove vm2 exclusion (since it is not required transitive dependency of urllib@2 anymore)

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner August 10, 2023 09:12
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit cdab7fe into master Aug 10, 2023
19 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-890305-bump-minor-urllib-version-and-remove-vm2-exlusion branch August 10, 2023 09:52
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-dprzybysz @sfc-gh-pbulawa