SNOW-844431: Return false for unsupported locatorsUpdateCopy() function in SnowflakeDatabaseMetadata.java #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-ext-simba-lb
force-pushed
the
SNOW-844431
branch
from
9847b4b
to
e06df35
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
sfc-gh-ext-simba-lb
changed the title
|
SonarQube Quality Gate
|
…ead of exception Revert "return reasonable value for describe database metadata functions instead of exception" This reverts commit e06df35. return false for locatorsUpdateCopy()
sfc-gh-ext-simba-lb
force-pushed
the
SNOW-844431
branch
from
9109f45
to
ff8e9d0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-844431
External contributors - please answer these questions before submitting a pull request. Thanks!
If an application makes a call to DatabaseMetadata describe function locatorsUpdateCopy(), a SnowflakeLoggedFeatureNotSupportedException is thrown and causes cascading failures.
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes Should not throw exceptions from certain methods in net.snowflake.client.jdbc.SnowflakeDatabaseMetaData #1416
https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/475
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Return false for this function instead of exception.
Pre-review checklist