Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "SNOW-848855: Change SLF4J scope to compile" #1463

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Revert "SNOW-848855: Change SLF4J scope to compile" #1463

merged 1 commit into from
Jul 6, 2023

Conversation

sfc-gh-mknister
Copy link
Contributor

@sfc-gh-mknister sfc-gh-mknister commented Jul 6, 2023 •
edited
Loading

Reverts #1462

We need to make this change without including the following lines:

SLF4J: No SLF4J providers were found.
! SLF4J: Defaulting to no-operation (NOP) logger implementation
! SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details.
! SLF4J: Class path contains SLF4J bindings targeting slf4j-api versions 1.7.x or earlier.
! SLF4J: Ignoring binding found at [jar:file:/mnt/jenkinsSF_REGRESS_ROOT/Client/henplus/lib/slf4j-jdk14-1.7.26.jar!/org/slf4j/impl/StaticLoggerBinder.class]
! SLF4J: See https://www.slf4j.org/codes.html#ignoredBindings for an explanation.

@sfc-gh-mknister sfc-gh-mknister requested a review from a team as a code owner July 6, 2023 19:19
@sfc-gh-mknister sfc-gh-mknister merged commit d008dd4 into master Jul 6, 2023
12 checks passed
@sfc-gh-mknister sfc-gh-mknister deleted the revert-1462-changeSlf4jScope branch July 6, 2023 19:27
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfc-gh-mknister