SNOW-844477: Allow connection property CLIENT_OUT_OF_BAND_TELEMETRY_ENABLED to disable OOB telemetry #1464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-844477
Out-of-band telemetry is enabled by default in the driver until a session is opened and the session properties are read. If CLIENT_OUT_OF_BAND_TELEMETRY_ENABLED is disabled on the account level and returned in the session properties, the telemetry will then be disabled. But since it is enabled before connection, if there are OCSP exceptions they will send telemetry requests.
External contributors - please answer these questions before submitting a pull request. Thanks!
Please answer these questions before submitting your pull requests. Thanks!
https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/478
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
To allow CLIENT_OUT_OF_BAND_TELEMETRY_ENABLED connection property to control if OOB telemetry is enabled or not. This can still be overridden by session properties later in the login flow. Part 2 will be on the server side to allow telemetry session properties to be configured by the user on the account level.
Pre-review checklist