Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-844477: Allow connection property CLIENT_OUT_OF_BAND_TELEMETRY_ENABLED to disable OOB telemetry #1464

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

sfc-gh-ext-simba-lb
Copy link
Contributor

Overview

SNOW-844477

Out-of-band telemetry is enabled by default in the driver until a session is opened and the session properties are read. If CLIENT_OUT_OF_BAND_TELEMETRY_ENABLED is disabled on the account level and returned in the session properties, the telemetry will then be disabled. But since it is enabled before connection, if there are OCSP exceptions they will send telemetry requests.

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/478

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  2. Please describe how your code solves the related issue.

    To allow CLIENT_OUT_OF_BAND_TELEMETRY_ENABLED connection property to control if OOB telemetry is enabled or not. This can still be overridden by session properties later in the login flow. Part 2 will be on the server side to allow telemetry session properties to be configured by the user on the account level.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb force-pushed the addOOBTelemetryConnectionProperty branch from 40fe898 to 6e2de0f Compare July 6, 2023 19:52
@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb marked this pull request as ready for review July 6, 2023 21:04
@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb requested a review from a team as a code owner July 6, 2023 21:04
@sonarqubemergegate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@sfc-gh-mknister sfc-gh-mknister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just had 1 clarification- did you get a chance to manually check that no OCSP OOB messages could get sent before SFSession.open() gets called? If so, this looks good.

@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb merged commit 6a8b926 into master Jul 14, 2023
12 checks passed
@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb deleted the addOOBTelemetryConnectionProperty branch July 14, 2023 17:28
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants