Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1631831: JDBC - handle TCP connection closure (traffic dependency request) #1872

Conversation

sfc-gh-jszczerbinski
Copy link
Contributor

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski commented Aug 20, 2024

Overview

SNOW-1631831

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski changed the title Rest request connection closed retries SNOW-1631831: Rest request connection closed retries Aug 21, 2024
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski force-pushed the SNOW-1631831-jdbc-handle-tcp-connection-closure-traffic-dependency-request branch from d471109 to 4501cb3 Compare August 23, 2024 07:59
@sfc-gh-jszczerbinski
Copy link
Contributor Author

  • Moved the wiremock test functionality to BaseWiremockTest (so ProxyLatestIT and RestRequestWiremockTest can share functionality)
  • Fixed the review comments

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski changed the title SNOW-1631831: Rest request connection closed retries SNOW-1631831: JDBC - handle TCP connection closure (traffic dependency request) Aug 23, 2024
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski force-pushed the SNOW-1631831-jdbc-handle-tcp-connection-closure-traffic-dependency-request branch from 20ea927 to b95fae5 Compare August 23, 2024 10:29
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski force-pushed the SNOW-1631831-jdbc-handle-tcp-connection-closure-traffic-dependency-request branch from 7f89cb5 to 5c16b1d Compare August 23, 2024 10:59
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski force-pushed the SNOW-1631831-jdbc-handle-tcp-connection-closure-traffic-dependency-request branch 2 times, most recently from 117391a to d5de68e Compare August 23, 2024 12:38
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski force-pushed the SNOW-1631831-jdbc-handle-tcp-connection-closure-traffic-dependency-request branch from d5de68e to 93bdbee Compare August 23, 2024 15:11
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski marked this pull request as ready for review August 23, 2024 16:00
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski requested a review from a team as a code owner August 23, 2024 16:00
@sfc-gh-mkubik sfc-gh-mkubik self-requested a review August 29, 2024 08:11
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski merged commit c7ead92 into master Sep 3, 2024
141 of 142 checks passed
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski deleted the SNOW-1631831-jdbc-handle-tcp-connection-closure-traffic-dependency-request branch September 3, 2024 13:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants