Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrow batches structured types #1879

Open
wants to merge 29 commits into
base: SNOW-873466-arrow-batches
Choose a base branch
from
Open

Arrow batches structured types #1879

wants to merge 29 commits into from

Conversation

sfc-gh-astachowski
Copy link
Collaborator

Overview

Added support for structured types (vector, list, map, struct)

Pre-review self checklist

  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)

Base automatically changed from arrow-batches-initial to SNOW-873466-arrow-batches August 30, 2024 11:44
@sfc-gh-astachowski sfc-gh-astachowski marked this pull request as ready for review September 3, 2024 14:22
@sfc-gh-astachowski sfc-gh-astachowski requested a review from a team as a code owner September 3, 2024 14:22
@sfc-gh-astachowski
Merge branch 'SNOW-873466-arrow-batches' into arrow-batches-structure…
bdca1db 
…d-types

# Conflicts:
#	src/main/java/net/snowflake/client/core/arrow/fullvectorconverters/ArrowFullVectorConverter.java
@sfc-gh-astachowski
Merge branch 'SNOW-873466-arrow-batches' into arrow-batches-structure…
4c9c8f2 
…d-types
@sfc-gh-astachowski
Merge fixes
3504d4f
@sfc-gh-astachowski
Merge branch 'SNOW-873466-arrow-batches' into arrow-batches-structure…
67ae0c4 
…d-types

# Conflicts:
#	src/main/java/net/snowflake/client/core/arrow/fullvectorconverters/ArrowFullVectorConverterUtil.java
#	src/test/java/net/snowflake/client/jdbc/ArrowBatchesIT.java
@sfc-gh-astachowski
Added try-with-resources
113af82
@sfc-gh-astachowski
Merge fixes and closing in finally blocks
44f9c15
sfc-gh-pbulawa
sfc-gh-pbulawa reviewed Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have some tests asserting the SFArrowException behavior.

src/main/java/net/snowflake/client/core/arrow/fullvectorconverters/TimeVectorConverter.java Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa left review comments

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-astachowski @sfc-gh-pbulawa @sfc-gh-pmotacki