Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 1.9.4 #666

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Release version 1.9.4 #666

merged 2 commits into from
Jul 12, 2023

Conversation

sfc-gh-rcheng
Copy link
Collaborator

Upgrades version to 1.9.4. See tag for rel notes

Testing

  • Load tests: IP
  • Chaos tests: IP

Copy link
Collaborator

@sfc-gh-japatel sfc-gh-japatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@sfc-gh-japatel sfc-gh-japatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets also modify Utils.java version

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #666 (7325f4f) into master (cf74b39) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
+ Coverage   87.95%   87.97%   +0.02%     
==========================================
  Files          50       50              
  Lines        4143     4143              
  Branches      451      451              
==========================================
+ Hits         3644     3645       +1     
+ Misses        331      330       -1     
  Partials      168      168              
Impacted Files Coverage Δ
...main/java/com/snowflake/kafka/connector/Utils.java 93.06% <ø> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-japatel
Copy link
Collaborator

This is still in draft, do you want to mark ready for review?

@sfc-gh-rcheng sfc-gh-rcheng marked this pull request as ready for review July 10, 2023 18:44
@sfc-gh-rcheng
Copy link
Collaborator Author

I don't want to merge this until we have run the necessary tests

@sfc-gh-rcheng
Copy link
Collaborator Author

Tests run: https://drive.google.com/drive/folders/1Voy-i7dHKudtf8n_0YIUdFtlmK6sNZ2W?usp=drive_link
Results look good, ready to merge and begin release process

@sfc-gh-rcheng sfc-gh-rcheng merged commit 0f570ee into master Jul 12, 2023
32 checks passed
@sfc-gh-rcheng sfc-gh-rcheng deleted the release-branch-v1.9.4 branch July 12, 2023 20:04
khsoneji pushed a commit to confluentinc/snowflake-kafka-connector that referenced this pull request Oct 12, 2023
khsoneji pushed a commit to confluentinc/snowflake-kafka-connector that referenced this pull request Oct 12, 2023
khsoneji pushed a commit to confluentinc/snowflake-kafka-connector that referenced this pull request Oct 12, 2023
khsoneji pushed a commit to confluentinc/snowflake-kafka-connector that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants