Revert "SNOW-811265 Do not close channel on rebalance (#651)" #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 52f0a8a.
sfc-gh-japatel
requested review from
sfc-gh-tzhang,
sfc-gh-tjones,
sfc-gh-rcheng and
a team
as code owners
sfc-gh-tjones
approved these changes
Jul 28, 2023
sfc-gh-rcheng
approved these changes
Jul 28, 2023
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
==========================================
- Coverage 87.97% 87.93% -0.05%
==========================================
Files 50 50
Lines 4143 4143
Branches 451 452 +1
==========================================
- Hits 3645 3643 -2
- Misses 330 331 +1
- Partials 168 169 +1
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sfc-gh-rcheng
pushed a commit
that referenced
this pull request
Jul 28, 2023
khsoneji
pushed a commit
to confluentinc/snowflake-kafka-connector
that referenced
this pull request
Oct 12, 2023
khsoneji
pushed a commit
to confluentinc/snowflake-kafka-connector
that referenced
this pull request
Oct 12, 2023
khsoneji
pushed a commit
to confluentinc/snowflake-kafka-connector
that referenced
this pull request
Oct 12, 2023
khsoneji
pushed a commit
to confluentinc/snowflake-kafka-connector
that referenced
this pull request
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 52f0a8a.
After careful consideration, we will revert "not closing channels" before a rebalance. i.e we will continue to close channel in
close()API of SinkTask.Closing the channel makes the behavior a bit more deterministic, closes resources and now that we have one client enabled, closing of channels wouldn't take a long time. (Probably only the first channel will take time but not subsequent)