Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH actions tests upgrade python from 3.6 to 3.9 #708

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

sfc-gh-rcheng
Copy link
Collaborator

@sfc-gh-rcheng sfc-gh-rcheng commented Sep 25, 2023

Python 3.6 is end of life and causing integration test github action runs to fail. Upgrade to 3.9 (similar to other tests)

@sfc-gh-rcheng sfc-gh-rcheng changed the title unify gh action python version to 3.9 GH actions tests upgrade python from 3.6 to 3.9 Sep 25, 2023
@sfc-gh-rcheng sfc-gh-rcheng marked this pull request as ready for review September 25, 2023 17:25
Copy link
Collaborator

@sfc-gh-japatel sfc-gh-japatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@sfc-gh-japatel sfc-gh-japatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully no big changes to successfully run all tests! Thanks

Copy link
Contributor

@sfc-gh-tzhang sfc-gh-tzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you know if we need to do something similar for the Ingest SDK?

@sfc-gh-rcheng
Copy link
Collaborator Author

LGTM, do you know if we need to do something similar for the Ingest SDK?

Probably, lets wait to see if the tests on 3.6 fail and then we can update

@sfc-gh-rcheng sfc-gh-rcheng merged commit 03bcba2 into master Sep 25, 2023
32 checks passed
@sfc-gh-rcheng sfc-gh-rcheng deleted the rcheng-pythonfix branch September 25, 2023 19:45
khsoneji pushed a commit to confluentinc/snowflake-kafka-connector that referenced this pull request Oct 12, 2023
khsoneji pushed a commit to confluentinc/snowflake-kafka-connector that referenced this pull request Oct 12, 2023
khsoneji pushed a commit to confluentinc/snowflake-kafka-connector that referenced this pull request Oct 12, 2023
khsoneji pushed a commit to confluentinc/snowflake-kafka-connector that referenced this pull request Oct 12, 2023
EduardHantig pushed a commit to streamkap-com/snowflake-kafka-connector that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants