Skip to content

Commit

Permalink
SNOW-897870: remove connector submodule in sqlalchemy (#442)
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-aling authored Aug 23, 2023
1 parent de68d86 commit 67f4152
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 55 deletions.
43 changes: 1 addition & 42 deletions .github/workflows/build_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,51 +97,10 @@ jobs:
.tox/.coverage
.tox/coverage.xml
test_connector_regression:
name: Connector Regression Test ${{ matrix.os.download_name }}-${{ matrix.python-version }}-${{ matrix.cloud-provider }}
needs: lint
runs-on: ${{ matrix.os.image_name }}
strategy:
fail-fast: false
matrix:
os:
- image_name: ubuntu-latest
download_name: manylinux_x86_64
python-version: ["3.8"]
cloud-provider: [aws]
steps:
- uses: actions/checkout@v2
with:
submodules: true
- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
- name: Display Python version
run: python -c "import sys; print(sys.version)"
- name: Setup parameters file
shell: bash
env:
PARAMETERS_SECRET: ${{ secrets.PARAMETERS_SECRET }}
run: |
gpg --quiet --batch --yes --decrypt --passphrase="$PARAMETERS_SECRET" \
.github/workflows/parameters/parameters_${{ matrix.cloud-provider }}.py.gpg > tests/connector_regression/test/parameters.py
- name: Upgrade setuptools, pip and wheel
run: python -m pip install -U setuptools pip wheel
- name: Install tox
run: python -m pip install tox
- name: List installed packages
run: python -m pip freeze
- name: Run tests
run: python -m tox -e connector_regression --skip-missing-interpreters false
env:
PYTEST_ADDOPTS: -vvv --color=yes --tb=short
TOX_PARALLEL_NO_SPINNER: 1

combine-coverage:
if: ${{ success() || failure() }}
name: Combine coverage
needs: [test, test_connector_regression]
needs: [test]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand Down
3 changes: 0 additions & 3 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,3 +0,0 @@
[submodule "tests/connector_regression"]
path = tests/connector_regression
url = [email protected]:snowflakedb/snowflake-connector-python
1 change: 0 additions & 1 deletion tests/connector_regression
Submodule connector_regression deleted from 6c365a
10 changes: 1 addition & 9 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ min_version = 4.0.0
envlist = fix_lint,
py{37,38,39,310,311}{,-pandas},
coverage,
connector_regression
skip_missing_interpreters = true

[testenv]
Expand Down Expand Up @@ -52,13 +51,6 @@ commands = pytest \
--run_v20_sqlalchemy \
{posargs:tests}

[testenv:connector_regression]
deps = pendulum
commands = pytest \
{env:SNOWFLAKE_PYTEST_OPTS:} \
-m "not gcp and not azure" \
{posargs:tests/connector_regression/test}

[testenv:.pkg_external]
deps = build
package_glob = {toxinidir}{/}dist{/}*.whl
Expand Down Expand Up @@ -94,7 +86,7 @@ commands = pre-commit run --all-files
python -c 'import pathlib; print("hint: run \{\} install to add checks as pre-commit hook".format(pathlib.Path(r"{envdir}") / "bin" / "pre-commit"))'

[pytest]
addopts = -ra --strict-markers --ignore=tests/sqlalchemy_test_suite --ignore=tests/connector_regression
addopts = -ra --strict-markers --ignore=tests/sqlalchemy_test_suite
junit_family = legacy
log_level = info
markers =
Expand Down

0 comments on commit 67f4152

Please sign in to comment.