Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-871115: add geometry support #429

Merged
merged 6 commits into from
Jul 28, 2023

Conversation

sfc-gh-aling
Copy link
Collaborator

@sfc-gh-aling sfc-gh-aling commented Jul 27, 2023

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-871115

echoing PR #427 with a couple of more changes

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
  2. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #429 (9b305d1) into main (e3f675e) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
+ Coverage   81.26%   81.32%   +0.05%     
==========================================
  Files          10       10              
  Lines        1281     1285       +4     
  Branches      192      192              
==========================================
+ Hits         1041     1045       +4     
  Misses        178      178              
  Partials       62       62              
Files Changed Coverage Δ
src/snowflake/sqlalchemy/__init__.py 83.33% <ø> (ø)
src/snowflake/sqlalchemy/snowdialect.py 77.87% <ø> (ø)
src/snowflake/sqlalchemy/base.py 91.57% <100.00%> (+0.06%) ⬆️
src/snowflake/sqlalchemy/custom_types.py 92.42% <100.00%> (+0.23%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix tests before merging!

🚢 🚢

@sfc-gh-aling sfc-gh-aling merged commit de68d86 into main Jul 28, 2023
17 of 18 checks passed
@sfc-gh-aling sfc-gh-aling deleted the SNOW-871115-add-geometry-support branch July 28, 2023 02:34
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants