-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDB Loader 5.2.0 #191
Merged
Merged
RDB Loader 5.2.0 #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for snowplow-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
stanch
requested changes
Nov 18, 2022
...ets/snowplow-rdb-loader/loading-transformed-data/rdb-loader-configuration-reference/index.md
Outdated
Show resolved
Hide resolved
...ets/snowplow-rdb-loader/loading-transformed-data/rdb-loader-configuration-reference/index.md
Outdated
Show resolved
Hide resolved
...ets/snowplow-rdb-loader/loading-transformed-data/rdb-loader-configuration-reference/index.md
Outdated
Show resolved
Hide resolved
...ets/snowplow-rdb-loader/loading-transformed-data/rdb-loader-configuration-reference/index.md
Outdated
Show resolved
Hide resolved
...ets/snowplow-rdb-loader/loading-transformed-data/rdb-loader-configuration-reference/index.md
Outdated
Show resolved
Hide resolved
...ets/snowplow-rdb-loader/loading-transformed-data/rdb-loader-configuration-reference/index.md
Show resolved
Hide resolved
...ets/snowplow-rdb-loader/loading-transformed-data/rdb-loader-configuration-reference/index.md
Outdated
Show resolved
Hide resolved
...ets/snowplow-rdb-loader/loading-transformed-data/rdb-loader-configuration-reference/index.md
Outdated
Show resolved
Hide resolved
...ets/snowplow-rdb-loader/loading-transformed-data/rdb-loader-configuration-reference/index.md
Outdated
Show resolved
Hide resolved
...ets/snowplow-rdb-loader/loading-transformed-data/rdb-loader-configuration-reference/index.md
Outdated
Show resolved
Hide resolved
Sorry, I create a small conflict in #192. Trivial to resolve, just a heads up |
spenes
force-pushed
the
rdb-loader-5.2.0
branch
from
November 20, 2022 22:37
c1b0a91
to
4e67523
Compare
stanch
requested changes
Nov 21, 2022
...ets/snowplow-rdb-loader/loading-transformed-data/rdb-loader-configuration-reference/index.md
Outdated
Show resolved
Hide resolved
...ets/snowplow-rdb-loader/loading-transformed-data/rdb-loader-configuration-reference/index.md
Outdated
Show resolved
Hide resolved
...ets/snowplow-rdb-loader/loading-transformed-data/rdb-loader-configuration-reference/index.md
Outdated
Show resolved
Hide resolved
...ets/snowplow-rdb-loader/loading-transformed-data/rdb-loader-configuration-reference/index.md
Outdated
Show resolved
Hide resolved
...ets/snowplow-rdb-loader/loading-transformed-data/rdb-loader-configuration-reference/index.md
Outdated
Show resolved
Hide resolved
stanch
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you just change (not needed
to (Not needed
before you land? Since it’s after the period
spenes
force-pushed
the
rdb-loader-5.2.0
branch
from
November 21, 2022 13:38
436866e
to
1d46e00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.