-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common-fs2: fix env var substitution for JSON files #753
Comments
Hi @marcin-j , If I'm not mistaken, substitution works with full values. Could you try with
and
please? |
Hi @benjben , It won't work this way either. I'm getting exact same error. According to HOCON docs it shouldn't matter wheter you use substitution with or without a string value.
I think it could be realted to |
Hey @marcin-j ,
Just to double-check, you tried exactly like this
|
@benjben yes the
command:
|
Hi @marcin-j , Indeed there is a bug, thanks for spotting it. You were already using substitution right in the first place, sorry about that. We'll release a fix shortly, I'll keep you posted. |
Hey @marcin-j , We've released |
Hi @benjben, Thanks for the update! Ive tested the new rc image, works great. Thanks! |
Hey, we have just updated from
The
We call the enrichment app in Docker like this:
|
Same here. Seems like there is regression, cause 3.7.1-rc1 doesn't resolve the Config file anymore |
It was fixed on @marcin-j hadn't you said that it was working with |
Hi @benjben, yes it was working. But Ive just built the image yesterday and it doesn't anymore. Im not sure what's wrong but I'm seeing exact same error about |
Hi @marcin-j , you build the image from |
I'm not sure to follow, have you actually built the image or have you run |
Oh sorry, we're actually using Docker Hub image to build our own image with some additions on top (like baking in config.hocon into the image etc.). That's why I said "built", but we base that image on your Docker Hub version:
|
I see. May I ask why you build your own image instead of using the original one directly ? I've published |
Of course, there are couple of reasons. We deploy Snowplow services via AWS ECS on FARGATE and we want to have additional layer of "caching" for situations like this. If anything changes on your Docker Hub, we still have our copy of image in our ECR repo and our prod version is referencing those ECR copies. Secondly, we add some additional layers to those images: enrichemnts directory, resolver config, enricher config. It's just easier to keep those in one place and call it via CMD (we actually have similar setup to this one). Version |
Thank you for following on this and checking so promptly! I also got the impression that in our case, |
Project: Stream Enrich
Version: 3.7.0
Expected behavior:
Since version 3.7.0 using environment variables substitutions should not trigger an error seen below. The config should be parsed.
Actual behavior:
It happens with
resolver.hocon
as well as all the other enrichments configs.Steps to reproduce:
/test
/test/resolver/resolver.json
/test/config.hocon
/test/enrichments/
just empty dir2. Run enricher with
The text was updated successfully, but these errors were encountered: