Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: do not validate enrichment names #767

Closed
stanch opened this issue Apr 10, 2023 · 0 comments
Closed

common: do not validate enrichment names #767

stanch opened this issue Apr 10, 2023 · 0 comments

Comments

@stanch
Copy link
Contributor

stanch commented Apr 10, 2023

Users are often confused by the “vendor” and “name” fields in the enrichment configs. They try to change them to reflect their own company or use case, only to discover that it does not work: the values must be exactly as shown in the examples.

However, there is no reason we need to validate or even use these fields, because the “schema” field already contains enough information. A more user-friendly solution would be to ignore “vendor” and “name” (eventually making them optional and phasing them out) and just use “schema”.

stanch added a commit that referenced this issue Apr 10, 2023
Users are often confused by the “vendor” and “name” fields in the enrichment configs.
There is no reason we need to validate or even use these fields, because the “schema” field already contains enough information.
This commit removes the validation on “name” (I believe “vendor” is not validated) and only uses “schema” instead.
@benjben benjben changed the title common: Avoid confusion with vendor/name fields that are not to be changed common: do not validate enrichment names Apr 11, 2023
@stanch stanch closed this as completed in 6a49696 Apr 11, 2023
@benjben benjben reopened this Apr 11, 2023
stanch added a commit that referenced this issue Apr 11, 2023
Users are often confused by the “vendor” and “name” fields in the enrichment configs.
There is no reason we need to validate or even use these fields, because the “schema” field already contains enough information.
This commit removes the validation on “name” (I believe “vendor” is not validated) and only uses “schema” instead.
spenes pushed a commit that referenced this issue Apr 13, 2023
Users are often confused by the “vendor” and “name” fields in the enrichment configs.
There is no reason we need to validate or even use these fields, because the “schema” field already contains enough information.
This commit removes the validation on “name” (I believe “vendor” is not validated) and only uses “schema” instead.
spenes pushed a commit that referenced this issue Apr 26, 2023
Users are often confused by the “vendor” and “name” fields in the enrichment configs.
There is no reason we need to validate or even use these fields, because the “schema” field already contains enough information.
This commit removes the validation on “name” (I believe “vendor” is not validated) and only uses “schema” instead.
spenes pushed a commit that referenced this issue Apr 26, 2023
Users are often confused by the “vendor” and “name” fields in the enrichment configs.
There is no reason we need to validate or even use these fields, because the “schema” field already contains enough information.
This commit removes the validation on “name” (I believe “vendor” is not validated) and only uses “schema” instead.
spenes pushed a commit that referenced this issue Apr 26, 2023
Users are often confused by the “vendor” and “name” fields in the enrichment configs.
There is no reason we need to validate or even use these fields, because the “schema” field already contains enough information.
This commit removes the validation on “name” (I believe “vendor” is not validated) and only uses “schema” instead.
@spenes spenes closed this as completed in c017f27 May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants