Set typeLoose to false in JSON Validator (close #122)

src/main/scala/com.snowplowanalytics.iglu/client/validator/CirceValidator.scala

@@ -194,12 +194,21 @@ object CirceValidator extends Validator[Json] {
   private val IgluMetaschemaFactory =
     JsonSchemaFactory.builder(JsonSchemaFactory.getInstance).addMetaSchema(IgluMetaschema).build()
 
+  private val SchemaValidatorsConfig: SchemaValidatorsConfig = {
+    val config = new SchemaValidatorsConfig()
+    // typeLoose is OpenAPI workaround to cast stringly typed properties
+    // e.g, with default true "5" string would validate against integer type
+    config.setTypeLoose(false)
+    config
+  };
+
   private lazy val V4Schema =
     JsonSchemaFactory.getInstance.getSchema(new ObjectMapper().readTree(V4SchemaText))
 
   def validate(data: Json, schema: Json): Either[ValidatorError, Unit] =
     Either
-      .catchNonFatal(IgluMetaschemaFactory.getSchema(circeToJackson(schema)))
+      .catchNonFatal(
+        IgluMetaschemaFactory.getSchema(circeToJackson(schema), SchemaValidatorsConfig))
       .leftMap[ValidatorError](ValidatorError.schemaIssue) // Should never be reached in Client
       .flatMap { schema =>
         validateOnReadySchema(schema, data).leftMap(ValidatorError.InvalidData.apply)

src/test/scala/com.snowplowanalytics.iglu.client/validator/RawValidationSpec.scala

@@ -37,6 +37,8 @@ class RawValidationSpec extends Specification with DataTables {
   additionalProperties invalidates unexpected property $e5
   ipv4 format invalidates plain string $e6
   validate integers bigger than java.lang.Long.MAX_VALUE $e7
+  validate null in [array, null] type $e8
+  invalidate stringly integer with integer type $e9
   """
 
   val simpleSchemaResult: Json =
@@ -194,6 +196,18 @@ class RawValidationSpec extends Specification with DataTables {
   def e7 = {
     val schema = json"""{ "type": "integer" }"""
     val input  = json"""9223372036854775809"""
-    CirceValidator.validate(input, schema) must beRight(())
+    CirceValidator.validate(input, schema) must beRight
+  }
+
+  def e8 = {
+    val schema = json"""{ "type": ["array", "null"], "items": {"type": "object"} }"""
+    val input  = json"""null"""
+    CirceValidator.validate(input, schema) must beRight
+  }
+
+  def e9 = {
+    val schema = json"""{ "type": "integer" }"""
+    val input  = json""""5""""
+    CirceValidator.validate(input, schema) must beLeft
   }
 }