Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded and in-memory lookups should be common across http modules #244

Closed
istreeter opened this issue May 25, 2023 · 0 comments
Closed

Comments

@istreeter
Copy link
Contributor

We maintain a couple of different implementations of a RegistryLookup, e.g. one based on java.net.http.HttpClient and one based on http4s.

The different implementations mainly differ in how they do http lookups. But they also need to provide implementations for lookups in non-http registries (embedded and in-memory). Over time, the implementations for the latter registry types have drifted apart. For example, this RegistryLookup can "list" schemas in an embedded registry (we added the feature in #212) but the http4s RegistryLookup returns NotFound for the equivalent lookup.

Another example... the http4s registry lookup recovers from all exceptions on a http lookup whereas the java.net.http.HttpClient registry lookup does not catch errors when listing schemas.

We can refactor the code so that a lot more is shared between the different implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant