Add caching to lookupSchemasUntil function #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spenes
force-pushed
the
enhancement/cache-lookup-schemas-until
branch
from
28a37c9
to
8128da8
Compare
spenes
commented
Sep 26, 2024
istreeter
approved these changes
Sep 26, 2024
benjben
approved these changes
Sep 26, 2024
modules/core/src/main/scala/com.snowplowanalytics.iglu/client/resolver/Resolver.scala
Show resolved
Hide resolved
modules/core/src/test/scala/com.snowplowanalytics.iglu.client/resolver/ResolverResultSpec.scala
Show resolved
Hide resolved
Also, lookupSchemasUntilResult function is implemented as well. It is the variant of lookupSchemasUntil that returns ResolverResult which contains information about cahe item. Also, mimaPreviousVersions is cleared out because this commit breaks binary compatibility with previous versions since it adds a new function to a trait. Therefore, we needed to clear-out the mimaPreviousVersions.
spenes
force-pushed
the
enhancement/cache-lookup-schemas-until
branch
from
8128da8
to
0037573
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ref: PDP-1479
This PR adds caching to
lookupSchemasUntilfunction. Also,lookupSchemasUntilResultfunction is implemented as well. It is the variant oflookupSchemasUntilthat returnsResolverResultwhich contains information about cahe item.