Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igluctl: fix false failure message in push command #313

Closed
chuwy opened this issue Jan 11, 2018 · 6 comments
Closed

igluctl: fix false failure message in push command #313

chuwy opened this issue Jan 11, 2018 · 6 comments
Assignees
Labels

Comments

@chuwy
Copy link
Contributor

chuwy commented Jan 11, 2018

When overriding an existing schema with 0.3.0 we're getting this error:

FAILURE: {
  "status" : 200,
  "message" : "Schema successfully updated",
  "location" : "/api/schemas/com.acme/event/jsonschema/1-0-0"
}

But upload actually works. 0.2.0 works without problems. It seems that problem is that Igluctl cannot deserialize above message into ServerMessage and ends up in this branch.

@oguzhanunlu, I believe this is same kind of problem we had with JSON Schema AST. Was that method also called asString?

@chuwy chuwy added the bug label Jan 11, 2018
@chuwy chuwy added this to the Release 8 Basel Dove milestone Jan 11, 2018
@oguzhanunlu oguzhanunlu mentioned this issue Jan 16, 2018
19 tasks
@oguzhanunlu
Copy link
Member

@chuwy , there were 2 methods and one of them was toString .

@chuwy
Copy link
Contributor Author

chuwy commented Jan 19, 2018

Hey @oguzhanunlu, here's info you requested.

Sorry - I didn’t give you enough information about this one. Basically "schema registry" here is ours Scala Repo Server. You can assemble a fatjar and try to upload schemas for example from Iglu Central to it. Another way would be to use Snowplow Mini for it, but I think former option should be much faster. So, just launch a Scala Registry on your local machine and everything else should be easy.

@chuwy
Copy link
Contributor Author

chuwy commented Jan 22, 2018

Hey @oguzhanunlu, just as heads-up, could you please check all iglu subprojects with Scala 2.12 for this json4s-extraction bug?

$ cd 0-common
$ grep -r extract\[ .

...or similar. We don't want to hit this in other places.

@oguzhanunlu
Copy link
Member

@chuwy , trying to reproduce, I can't assemble scala repo server, I get java.lang.NoSuchMethodError: sbt.Keys$.compatibilityWarningOptions()Lsbt/SettingKey error after running sbt assembly. I use java 7 as pointed here . I wanted to download its jar directly but it is not specified yet. Can you assemble?

@chuwy
Copy link
Contributor Author

chuwy commented Jan 24, 2018

@oguzhanunlu our compiled assets available at http://dl.bintray.com/snowplow/snowplow-generic/ (please fix the wiki page, also).

Problem most likely that you have SBT 1.0, while repo uses very old one. To avoid issues like this, please use Vagrantfile from project root. This is supposed to be default approach.

@oguzhanunlu
Copy link
Member

@chuwy Your first assumption is true. Problem is asString. I also checked all Iglu subprojects for similar behavior and didn't encounter any.

@chuwy chuwy closed this as completed in 61790d1 Feb 7, 2018
rzats pushed a commit to snowplow/igluctl that referenced this issue Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants