Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds additional linting to make description required (solves #264) #266

Closed
wants to merge 1 commit into from

Conversation

miike
Copy link

@miike miike commented Oct 3, 2017

This adds support for the description property and adds a new severity level for linting that makes the description property mandatory. Related: #264

@snowplowcla
Copy link

@miike has signed the Software Grant and Corporate Contributor License Agreement

Copy link
Contributor

@chuwy chuwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @miike!

In the next version we'll probably change severity level notion to something more flexible (#232), so in the end this feature will have different API, but overall I like it!

@miike
Copy link
Author

miike commented Oct 4, 2017

Agreed - that was something I was thinking about while implementing this. I wonder if it should be passed in via CLI or possibly have a minimal configuration file for the linter.

@chuwy
Copy link
Contributor

chuwy commented Oct 4, 2017

I'm leaning towards CLI option. Something like --checks description,size,some_other_check and --checks all. I think scope of igluctl is too tiny to have a dedicated configuration format.

@miike
Copy link
Author

miike commented Oct 4, 2017

Fair enough - a configuration file is probably overkill at this point.

@chuwy chuwy added this to the Release 8 Stamp TBC milestone Dec 15, 2017
@oguzhanunlu oguzhanunlu removed this from the Release 8 Basel Dove milestone Dec 18, 2017
@oguzhanunlu
Copy link
Member

Cherry-picked to #309, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants