Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enrichment upload mechanism #194

Closed
jbeemster opened this issue May 27, 2019 · 2 comments
Closed

Fix enrichment upload mechanism #194

jbeemster opened this issue May 27, 2019 · 2 comments
Assignees
@oguzhanunlu
Labels
bug
Milestone
Version 0.6.1

Comments

@jbeemster
Copy link
Member

For some reason the upload of enrichment does not replace the whole file but rather just changes the lines in the file - in the case that the old enrichment JSON is longer than the new one you will end up with corrupted input which will break Stream Enrich.
@jbeemster jbeemster added the bug label May 27, 2019
@jbeemster
Copy link
Member Author

This function needs to delete the existing file first or at least empty it out before attempting upload:

https://github.com/snowplow/snowplow-mini/blob/master/provisioning/resources/control-plane/main.go#L98-L103

@oguzhanunlu
Copy link
Member

Just like here https://github.com/snowplow/snowplow-mini/blob/master/provisioning/resources/control-plane/main.go#L148-L155 . All config updating functions must follow this approach.

@oguzhanunlu oguzhanunlu self-assigned this May 28, 2019
@oguzhanunlu oguzhanunlu changed the title When uploading an enrichment the new JSON must be longer than the old JSON or the overwrite fails Fix enrichment upload logic May 31, 2019
@oguzhanunlu oguzhanunlu changed the title Fix enrichment upload logic Fix enrichment upload mechanism May 31, 2019
@oguzhanunlu oguzhanunlu added this to the Version 0.6.1 milestone May 31, 2019
oguzhanunlu added a commit that referenced this issue Jun 3, 2019
@oguzhanunlu
Fix enrichment upload mechanism (closes #194)
c78c64b
oguzhanunlu added a commit that referenced this issue Jun 3, 2019
@oguzhanunlu
Fix enrichment upload mechanism (closes #194)
d56c657
oguzhanunlu added a commit that referenced this issue Jun 5, 2019
@oguzhanunlu
Fix enrichment upload mechanism (closes #194)
1cc307d
oguzhanunlu added a commit that referenced this issue Jun 5, 2019
@oguzhanunlu
Fix enrichment upload mechanism (closes #194)
7255b6b
oguzhanunlu added a commit that referenced this issue Jun 10, 2019
@oguzhanunlu
Fix enrichment upload mechanism (closes #194)
db75f96
oguzhanunlu added a commit that referenced this issue Jun 11, 2019
@oguzhanunlu
Fix enrichment upload mechanism (closes #194)
bd6b2d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oguzhanunlu oguzhanunlu

Labels
bug
Projects
None yet
Milestone
Version 0.6.1
Development

No branches or pull requests
2 participants
@oguzhanunlu @jbeemster