Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy iglu_server_upload.sh script #58

Closed
jbeemster opened this issue Jun 29, 2016 · 8 comments
Closed

Remove legacy iglu_server_upload.sh script #58

jbeemster opened this issue Jun 29, 2016 · 8 comments
Assignees
Milestone

Comments

@jbeemster
Copy link
Member

We are using a Python insert in the script to parse the returned JSON, this is only compatible with 2.X and will throw errors on newer versions of Python.

Change to: print statement to 'print(obj["status"])'

@jbeemster jbeemster added this to the Version 0.3.0 milestone Jun 29, 2016
@jbeemster jbeemster self-assigned this Jun 29, 2016
@alexanderdean
Copy link
Member

This should be superceded by igluctl - @chuwy should have the details...

@chuwy
Copy link

chuwy commented Jun 29, 2016

Hey @jbeemster. Currently I have a full port of iglu_upload_script written in Scala (planning to release it on next week with Iglu 5). If you have any new features on your mind - just create corresponding ticket in snowplow/iglu.

@jbeemster
Copy link
Member Author

Hey @chuwy! No extra ideas we just needed to make a note of this as the current script is breaking upload for those on Python 3.X.

How would users go about using the scalafied script with snowplow-mini?

@chuwy
Copy link

chuwy commented Jun 29, 2016

Hm that's a good question. I think we're comparing here plain python script (python interpreter is installed on about 99% of modern computers) and jar (JRE is installed on fewer machines, I guess).

Do we bundle any more CLI tools along with snowplow-mini?

@alexanderdean alexanderdean changed the title Update iglu_upload_script to work with newer versions of Python Replace iglu_upload_script with igluctl Aug 11, 2016
@alexanderdean
Copy link
Member

Fixed title

@yalisassoon
Copy link
Member

I think this is done - we instruct clients to use:

$ /path/to/igluctl static push /path/to/schemas/com.mycompany {{ snowplow-mini ip }}:8081 {{ snowplow-mini iglu server key (uuid) }}

The full instructions we share with clients is here: https://github.com/snowplow/iglu-example-schema-registry/blob/master/README.md

@alexanderdean
Copy link
Member

Right - so this is probably just about deleting any legacy scripts from the repo...

@alexanderdean alexanderdean assigned chuwy and unassigned jbeemster Apr 12, 2017
@alexanderdean alexanderdean changed the title Replace iglu_upload_script with igluctl Remove legacy iglu_upload_script Apr 12, 2017
@alexanderdean alexanderdean assigned aldemirenes and unassigned chuwy Jun 16, 2017
@aldemirenes aldemirenes reopened this Jun 19, 2017
@alexanderdean alexanderdean changed the title Remove legacy iglu_upload_script Remove legacy iglu_server_upload.sh script Jul 6, 2017
@alexanderdean
Copy link
Member

Improved title, please reword commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants