Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDB Shredder: turn into SBT submodule #27

Closed
chuwy opened this issue Aug 21, 2017 · 8 comments
Closed

RDB Shredder: turn into SBT submodule #27

chuwy opened this issue Aug 21, 2017 · 8 comments

Comments

@chuwy
Copy link
Contributor

chuwy commented Aug 21, 2017

Both RDB Loader and RDB Shredder going to be released together (by lucky coincidence they both now versioned 0.12.0).

@BenFradet
Copy link
Contributor

That's quite opportunistic, I like it 👍

@alexanderdean
Copy link
Member

How will the versioning work - they will both share a unified version?

@chuwy
Copy link
Contributor Author

chuwy commented Aug 21, 2017

That's an option that I consider. And that's what we're doing for elasticsearch (I suppose) and our another loader.

But it is possible to version them differently.

@BenFradet
Copy link
Contributor

The situation is a bit different with the elasticsearch loader in that we support multiple es versions/apis but do the same thing (consume some stream and produce to es).

@chuwy
Copy link
Contributor Author

chuwy commented Aug 21, 2017

Ok, I don't have a strong opinion on it. Right now I see that StorageLoader and Hadoop Shred shared very little and there was no point to share code between them, but on the other hand I can imagine things change significantly.

@alexanderdean
Copy link
Member

If we have separate version numbers for each (which I'm not against), how do we version overall releases in this repo?

@chuwy
Copy link
Contributor Author

chuwy commented Aug 21, 2017

I can imagine somewhat similar to JS Tracker's approach. 0.13.0 releases Loader 0.13.0, shredder/0.13.0 releases Shredder.

The only cons I see in same-version approach is that if we don't make any changes in Shredder in 0.x.0 release - asset still will be published on S3 without changes from previous version. We will have same assets with different versions.

@alexanderdean
Copy link
Member

I think I am leaning towards independent version numbers, deployment per @chuwy's comment and Release N, Release N+1 in the release notes / CHANGELOG. But let me know what you two think...

@chuwy chuwy added this to the Version 0.13.0 milestone Sep 5, 2017
@chuwy chuwy changed the title Turn RDB Shredder into SBT submodule RDB Shredder: turn into SBT submodule Sep 6, 2017
@chuwy chuwy closed this as completed in 55d8827 Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants