-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDB Shredder: turn into SBT submodule #27
Comments
That's quite opportunistic, I like it 👍 |
How will the versioning work - they will both share a unified version? |
That's an option that I consider. And that's what we're doing for elasticsearch (I suppose) and our another loader. But it is possible to version them differently. |
The situation is a bit different with the elasticsearch loader in that we support multiple es versions/apis but do the same thing (consume some stream and produce to es). |
Ok, I don't have a strong opinion on it. Right now I see that StorageLoader and Hadoop Shred shared very little and there was no point to share code between them, but on the other hand I can imagine things change significantly. |
If we have separate version numbers for each (which I'm not against), how do we version overall releases in this repo? |
I can imagine somewhat similar to JS Tracker's approach. The only cons I see in same-version approach is that if we don't make any changes in Shredder in |
I think I am leaning towards independent version numbers, deployment per @chuwy's comment and Release N, Release N+1 in the release notes / CHANGELOG. But let me know what you two think... |
Both RDB Loader and RDB Shredder going to be released together (by lucky coincidence they both now versioned 0.12.0).
The text was updated successfully, but these errors were encountered: