-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDB Loader: track when a load succeeded #574
Labels
Milestone
Comments
The whole Snowplow-tracking behavior is big a left-over from very old days I think apart from what you said already, we should:
|
chuwy
added a commit
that referenced
this issue
Dec 9, 2021
chuwy
added a commit
that referenced
this issue
Dec 9, 2021
chuwy
added a commit
that referenced
this issue
Dec 10, 2021
chuwy
added a commit
that referenced
this issue
Dec 28, 2021
chuwy
added a commit
that referenced
this issue
Dec 29, 2021
chuwy
added a commit
that referenced
this issue
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Monitoring interpreter is able to track either a failed load or a successful load. But we only ever call it on a failure. We never call the
track
method if the load was successful.I assume this is a mistake? If it is deliberate, then I suggest re-define the
track
method to only accept aLoaderError
instead of an Either.The text was updated successfully, but these errors were encountered: