Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDB Loader: track when a load succeeded #574

Closed
istreeter opened this issue Sep 15, 2021 · 1 comment
Closed

RDB Loader: track when a load succeeded #574

istreeter opened this issue Sep 15, 2021 · 1 comment
Milestone

Comments

@istreeter
Copy link
Contributor

The Monitoring interpreter is able to track either a failed load or a successful load. But we only ever call it on a failure. We never call the track method if the load was successful.

I assume this is a mistake? If it is deliberate, then I suggest re-define the track method to only accept a LoaderError instead of an Either.

@chuwy
Copy link
Contributor

chuwy commented Sep 21, 2021

The whole Snowplow-tracking behavior is big a left-over from very old days

I think apart from what you said already, we should:

  1. Track more infroamtion, for example volume, amount of contexts, time loading and shredding took. This is up to debate though because it will be mostly duplicated with RDB Loader: report metrics to StatsD or Stdout #384
  2. We can resurrect load_suceeded schema as 2-0-0 with this info
  3. On a less related note, we should define a more clear strategy for monitoring and failure handling - right now these methods called somewhat sporadically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants