Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.1.0 #948

Closed
wants to merge 5 commits into from
Closed

Release 4.1.0 #948

wants to merge 5 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

Created by Github Actions

@snowplowcla
Copy link
Collaborator

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

@istreeter
Copy link
Contributor

@voropaevp I made a few amendments while I was testing it out -- I hope that's OK:

  • Removed the \n character from the message derived from the SqlException. Only because this message gets sent to our alerting services and I don't know how it would look there.
  • Added config validation for Snowflake so we don't get nasty exceptions thrown on account.get or region.get.
  • Removed account from the Snowflake jdbc properties, now that it's optional. I don't think it does anything anyway -- it's not listed in the Snowflake connection parameter reference.
  • Removed my commit for the collector_tstamp_date column because we're going to do it with Databricks loader: Support for generated columns #951 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants