Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): get_all_videos_id_by_channel returning no results #175

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

pidi3000
Copy link
Contributor

@pidi3000 pidi3000 commented Apr 29, 2024

fixes #174

Previously if the response of api.search() had no nextPageToken (channel has less then 50 videos) the while loop would not run at all and return an empty list.

changing the while loop into a do-while loop ensures that code inside the loop is run at least once.

@MerleLiuKun
Copy link
Member

wow good job!

@MerleLiuKun MerleLiuKun merged commit 7076d19 into sns-sdks:master Apr 30, 2024
7 of 8 checks passed
@pidi3000 pidi3000 deleted the fix-examples branch April 30, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code example get_all_videos_id_with_channel_by_search.py
2 participants