Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #212 rest pagination validation #213

Closed
wants to merge 2 commits into from

Conversation

IanYoung-BO
Copy link
Contributor

@IanYoung-BO IanYoung-BO commented Dec 27, 2023

Initially reported in #212

This PR adds additional validation to the data returned from paginated REST endpoints. In some cases, the server will return pages of zero length, or the next link value will be the same page. This may be due to incomplete implementations of beta endpoints. However, these additional checks will allow for use of more endpoints that are available.

@garethr
Copy link
Collaborator

garethr commented Jan 13, 2024

Thanks, I've fixed up a formatting issue and merged in 47ce10a. Much appreciated.

@garethr garethr closed this Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants