test: refactor to use assert.NoError (#5230)

snyk · May 29, 2024 · 3ebfbd3 · 3ebfbd3
1 parent d048444
commit 3ebfbd3
Showing 1 changed file with 4 additions and 12 deletions.
diff --git a/cliv2/cmd/cliv2/main_test.go b/cliv2/cmd/cliv2/main_test.go
@@ -120,9 +120,7 @@ func Test_CreateCommandsForWorkflowWithSubcommands(t *testing.T) {
 		workflowConfig := workflow.ConfigurationOptionsFromFlagset(pflag.NewFlagSet("pla", pflag.ContinueOnError))
 		workflowId1 := workflow.NewWorkflowIdentifier(v)
 		_, err := globalEngine.Register(workflowId1, workflowConfig, fn)
-		if err != nil {
-			t.Fatal(err)
-		}
+		assert.NoError(t, err)
 	}
 
 	_ = globalEngine.Init()
@@ -195,9 +193,7 @@ func Test_runMainWorkflow_unknownargs(t *testing.T) {
 				workflowConfig := workflow.ConfigurationOptionsFromFlagset(pflag.NewFlagSet("pla", pflag.ContinueOnError))
 				workflowId1 := workflow.NewWorkflowIdentifier(v)
 				_, err := globalEngine.Register(workflowId1, workflowConfig, fn)
-				if err != nil {
-					t.Fatal(err)
-				}
+				assert.NoError(t, err)
 			}
 
 			_ = globalEngine.Init()
@@ -356,9 +352,7 @@ func Test_runWorkflowAndProcessData(t *testing.T) {
 	workflowConfig := workflow.ConfigurationOptionsFromFlagset(pflag.NewFlagSet("pla", pflag.ContinueOnError))
 
 	_, err := globalEngine.Register(workflowId1, workflowConfig, outputFn)
-	if err != nil {
-		t.Fatal(err)
-	}
+	assert.NoError(t, err)
 
 	fn := func(invocation workflow.InvocationContext, input []workflow.Data) ([]workflow.Data, error) {
 		typeId := workflow.NewTypeIdentifier(invocation.GetWorkflowIdentifier(), "workflowData")
@@ -376,9 +370,7 @@ func Test_runWorkflowAndProcessData(t *testing.T) {
 
 		var d []byte
 		d, err = json.Marshal(testSummary)
-		if err != nil {
-			t.Fatal(err)
-		}
+		assert.NoError(t, err)
 
 		data := workflow.NewData(typeId, content_type.TEST_SUMMARY, d)
 		return []workflow.Data{