Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unused exports linter and fixing #2130

Closed
wants to merge 2 commits into from

Conversation

teodora-sandu
Copy link
Contributor

What does this PR do?

This PR adds a linter for unused exports, which ensures that once we stop using an export we'll be notified.

Where should the reviewer start?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2021

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 9918857

@teodora-sandu teodora-sandu force-pushed the chore/remove-unused-files branch 3 times, most recently from c3f6c74 to e3cbb18 Compare August 2, 2021 07:57
@@ -1,6 +1,7 @@
const Configstore = require('configstore');
const pkg = require(__dirname + '/../../package.json');

// eslint-disable-next-line import/no-unused-modules
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running into the following bug which was fixed in [email protected] if we don't export it: microsoft/TypeScript#40718

@@ -45,6 +45,7 @@ export class TestLimitReachedError extends CustomError {

// Sub-interface of FormattedResult that we really only use to make test
// fixtures easier to create.
// eslint-disable-next-line import/no-unused-modules
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running into the following bug which was fixed in [email protected] if we don't export it: microsoft/TypeScript#40718

@@ -31,6 +31,7 @@ const simpleGradleGraph = depGraphLib.createFromJSON({
},
});

// eslint-disable-next-line import/no-unused-modules
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky test is temporarily disabled/commented out, so disabling the rule for this export.

@ghost
Copy link

ghost commented Apr 12, 2022

Closing due to age. Feel free to re-open if it's still active.

@ghost ghost closed this Apr 12, 2022
@darscan darscan deleted the chore/remove-unused-files branch January 20, 2023 17:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant