chore: Create smoke tests for experimental IaC tests #3838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofekatr
force-pushed
the
chore/create-iac-e2e-tests-cfg-2106
branch
30 times, most recently
from
7b34004
to
9c9f26e
Compare
ofekatr
force-pushed
the
chore/create-iac-e2e-tests-cfg-2106
branch
26 times, most recently
from
b2a8574
to
17a9483
Compare
ofekatr
force-pushed
the
chore/create-iac-e2e-tests-cfg-2106
branch
from
17a9483
to
8890fb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Notes for the reviewer
IAC_SMOKE_TESTS_SNYK_TOKENsecret with the authentication token was yet to be added by team Hammer, so the tests still fail on the authentication step of thesnyk iac test --experimentalcommand.Any background context you want to provide?
After CFG-2061: Spike options for testing/monitoring resources availability for the CLI , we ended up on agreeing that a smoke test which downloads the artefacts and runs an IaC scan will give us enough confidence that the reyling artefacts are available and scans are working.
Language of choice: Jest
CI of choice: Github Action
Note: Jest vs shellspec was a tie in the original spike, I reached out to Hammer to see if they have seen any benefits of using shellspec, and I think they just transferred them to shellspec for historic reasons. they are actually thinking of keeping one language and leaning to migrate them to jest for v2.
What are the relevant tickets?