feat: add flag to exclude app vulnerabilities #3874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tommyknows
force-pushed
the
feat/no-app-vulns
branch
3 times, most recently
from
0f60525
to
6623a4a
Compare
yaronschwimmer
approved these changes
Sep 28, 2022
tommyknows
force-pushed
the
feat/no-app-vulns
branch
2 times, most recently
from
1979ad6
to
acebdaa
Compare
Although we already have a `--app-vulns` flag, the plan is to enable app-vulnerability scanning in containers by default. Before doing that, we want to give customers the opportunity to explicitly opt-out of the change in the default by introducing a new flag `--exclude-app-vulns`. This flag will co-exist with the `--app-vulns` flag until it's enabled by default, at which point the `--app-vulns` flag can be removed.
We want to notify customers about the upcoming change to scan app vulns by default in the CLI. As such, this commit adds a warning message whenever `container monitor` or `container test` is executed.
tommyknows
force-pushed
the
feat/no-app-vulns
branch
from
acebdaa
to
9216c49
Compare
Avishagp
approved these changes
Oct 3, 2022
gitphill
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Although we already have a
--app-vulnsflag, the plan is to enable app-vulnerability scanning in containers by default. Before doing that, we want to give customers the opportunity to explicitly opt-out of the change in the default by introducing a new flag--exclude-app-vulns. This flag will co-exist with the--app-vulnsflag until it's enabled by default, at which point the--app-vulnsflag can be removed.Additionally (second commit) it adds a warning message regarding the app-vuln enablement:
How should this be manually tested?
Run
snyk container testwithout the--app-vulnsflag, where the message should show up. Add--jsonand see how the message magically disappears :)What are the relevant tickets?
https://snyksec.atlassian.net/browse/MYC-163
https://snyksec.atlassian.net/browse/MYC-175