-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add SCM report test support [ZEN-668] #4745
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotkas
approved these changes
Jul 17, 2023
novalex
force-pushed
the
feat/ZEN-668/add-scm-report-test-support
branch
from
July 17, 2023 08:02
8069136
to
1fbe158
Compare
asaf92
approved these changes
Jul 17, 2023
patricia-v
reviewed
Jul 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙌
Once again, I'll leave the final approval to @michelkaporin 😁
novalex
force-pushed
the
feat/ZEN-668/add-scm-report-test-support
branch
2 times, most recently
from
July 18, 2023 15:19
4b1443d
to
069d48d
Compare
michelkaporin
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving the codebase in a better state, great work! :)
novalex
force-pushed
the
feat/ZEN-668/add-scm-report-test-support
branch
from
July 19, 2023 08:29
069d48d
to
a5274d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements support for running Code tests against existing SCM projects and uploading/reporting results under them.
AKA CLI Uploads Phase 2, AKA CLI-triggered SCM Tests.
Follows the existing
--report
flow logic, with some distinctions:--project-id
and--commit-id
instead of--project-name
as used by the files flow. That is because the files flow can create or fetch a CLI project, whereas this one relies on an SCM Code project existing.analyzeScmProject
fromcode-client
, instead ofanalyzeFolders
. That is because it triggers an SCM analysis in our backend, and does not need to upload local files first like the file-based flow.Otherwise the interfaces and handling logic are very similar.
Where should the reviewer start?
How should this be manually tested?
Make sure
--commit-id
is a valid commit available on the remote SCM your Snyk project is linked to.Any background context you want to provide?
What are the relevant tickets?
https://snyksec.atlassian.net/browse/ZEN-668
Screenshots
Additional questions