[NEBULA-549] fix: lock needle version to 3.0.x #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soniqua
approved these changes
May 9, 2022
florinMiro
approved these changes
May 9, 2022
novalex
approved these changes
May 9, 2022
metju90
approved these changes
May 9, 2022
|
🎉 This PR is included in version 4.12.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://snyksec.atlassian.net/browse/NEBULA-549
Fix needle version to 3.0.x, not 3.x.y. This prevents us from pulling in tomas/needle#382 which causes problems with how we're currently using global-agent to configure the proxy for code-client, both in cli and code-agent.
In parallel we will look into a more permanent solution that is compatible with newer needle versions and properly uses CONNECT requests, e.g., tunnel.