fix: avoid stack overflow with spread operator #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ivanstanev
force-pushed
the
fix/avoid-spread-stack-overflow
branch
from
4be7c30
to
84a9efc
Compare
A customer cannot scan their project with a supposedly very large dependency graph because as soon as it reaches our back-end, we get a stack overflow error. It was identified that the error is due to the combination of Array.push() and the spread operator. For reference: nodejs/node#16870 To reproduce, create an array of size 2^17 then do [].push(...myArray); This fix replaces all uses of push() and spread with a simple loop.
darscan
force-pushed
the
fix/avoid-spread-stack-overflow
branch
from
84a9efc
to
0bd6afb
Compare
darscan
approved these changes
Oct 24, 2019
|
🎉 This PR is included in version 1.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer cannot scan their project with a supposedly very large dependency graph because as soon as it reaches our back-end, we get a stack overflow error. It was identified that the error is due to the combination of Array.push() and the spread operator.
For reference: nodejs/node#16870
To reproduce, create an array of size 2^17 then do [].push(...myArray);.
This fix replaces all uses of push() and spread with a simple loop.
How should this be manually tested?
What are the relevant tickets?
Zendesk Ticket 2194