Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Azure azurerm_resource_group (TF) #1029

Closed
sjourdan opened this issue Sep 14, 2021 · 3 comments
Closed

Support Azure azurerm_resource_group (TF) #1029

sjourdan opened this issue Sep 14, 2021 · 3 comments
Assignees
Labels
kind/enhancement New feature or improvement

Comments

@sjourdan
Copy link
Contributor

Description

Add Azure support for azurerm_resource_group (TF)

Sources

@sundowndev
Copy link
Contributor

sundowndev commented Sep 28, 2021

After investigating this resource it seems that it's just not possible to implement it for now. This is due to the Azure SDK mixing go module/non-module code in the same repository. A lot of packages still need to be migrated to a proper Go module, including github.com/Azure/azure-sdk-for-go/sdk/resources/armresources which is required to implement this resource. Package migrations should be tracked in this issue Azure/azure-sdk-for-go#14387. Import issues should be tracked in this issue Azure/azure-sdk-for-go#15384.

@sundowndev
Copy link
Contributor

Unblocked by #1081

@sjourdan
Copy link
Contributor Author

sjourdan commented Oct 7, 2021

LGTM with various manual+tf

❯  AZURE_SUBSCRIPTION_ID="7bfb2c5c-7308-46ed-8ae4-fffa356eb406" LOG_LEVEL=error driftctl-0.16-pre scan --to azure+tf
Found resources not covered by IaC:
  azurerm_resource_group:
    - /subscriptions/7bfb2c5c-7308-46ed-8ae4-fffa356eb406/resourceGroups/manual-qa-rg-uk-1
        Name: manual-qa-rg-uk-1
Found 9 resource(s)
 - 88% coverage
 - 8 resource(s) managed by terraform
     - 0/8 resource(s) out of sync with Terraform state
 - 1 resource(s) not managed by Terraform
 - 0 resource(s) found in a Terraform state but missing on the cloud provider
Scan duration: 2s

or

❯  AZURE_SUBSCRIPTION_ID="7bfb2c5c-7308-46ed-8ae4-fffa356eb406" LOG_LEVEL=error driftctl-0.16-pre scan --to azure+tf
Found missing resources:
  From tfstate://terraform.tfstate
    - /subscriptions/7bfb2c5c-7308-46ed-8ae4-fffa356eb406/resourceGroups/qa-rg-2 (azurerm_resource_group.qa-rg-2)
        Name: qa-rg-2
Found 8 resource(s)
 - 87% coverage
 - 7 resource(s) managed by terraform
     - 0/7 resource(s) out of sync with Terraform state
 - 0 resource(s) not managed by Terraform
 - 1 resource(s) found in a Terraform state but missing on the cloud provider
Scan duration: 3s

@sjourdan sjourdan closed this as completed Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

3 participants